Skip to content

Make kubernetes "repo" volume configurable.

Jan Smets requested to merge jansmets/gitlab-runner:k8s-configurable-repo-volume into master

What does this MR do?

Make the kubernetes executor "repo" volume configurable. (eg, as PVC).

When no (or empty) host_path is configured then the host_path will default to BuildDir. This makes it easy to drop in a PVC with name "repo" as replacement

Why was this MR needed?

This volume defaults to EmptyDir. On cluster nodes with no storage the emptyDir volumes are on memory storage.

This change is also a required when administrators (along with some other changes) want to use persistent storage for incremental builds. This is extremely valuable for larger projects.

Are there points in the code the reviewer needs to double check?

The default emptyDir behavior is unchanged, which existing the test leverage.

I'm not sure what the best way is to document this.

I was also doubting whether or not to have (yet) an additional config flag so that the "repo" volume -name- can be configured. (ie, so that the PVC does not require the name "repo")

Feedback appreciated. Thank you

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased
Edited by 🤖 GitLab Bot 🤖

Merge request reports