You need to sign in or sign up before continuing.
Flaky race condition in TestCommand_Run/command_times_out
Usually TestCommand_Run/command_times_out
is marked to be racey and has 3 data races associated with it https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/589554999:
Normal output
=== RUN TestCommand_Run/command_times_out
==================
WARNING: DATA RACE
Read at 0x00c000032228 by goroutine 12:
fmt.(*pp).printValue()
/usr/local/go/src/reflect/value.go:982 +0x359a
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:687 +0xf1a
github.com/stretchr/testify/mock.(*Mock).findExpectedCall()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:269 +0x16a
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:348 +0xb3
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockKillWaiter).KillAndWait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_KillWaiter.go:14 +0xfe
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:77 +0x482
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Previous write at 0x00c000032228 by goroutine 13:
sync/atomic.CompareAndSwapInt32()
/usr/local/go/src/runtime/race_amd64.s:293 +0xb
sync.(*Mutex).Lock()
/usr/local/go/src/sync/mutex.go:74 +0x49
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:346 +0x61
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Goroutine 12 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 13 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Write at 0x00c000032228 by goroutine 13:
sync/atomic.CompareAndSwapInt32()
/usr/local/go/src/runtime/race_amd64.s:293 +0xb
sync.(*Mutex).Lock()
/usr/local/go/src/sync/mutex.go:74 +0x49
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:346 +0x61
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Previous read at 0x00c000032228 by goroutine 12:
reflect.typedmemmove()
/usr/local/go/src/runtime/mbarrier.go:177 +0x0
reflect.packEface()
/usr/local/go/src/reflect/value.go:119 +0x103
reflect.valueInterface()
/usr/local/go/src/reflect/value.go:1033 +0x16f
fmt.(*pp).printValue()
/usr/local/go/src/reflect/value.go:1003 +0x38f7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:687 +0xf1a
github.com/stretchr/testify/mock.(*Mock).findExpectedCall()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:269 +0x16a
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:348 +0xb3
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockKillWaiter).KillAndWait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_KillWaiter.go:14 +0xfe
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:77 +0x482
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 13 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 12 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Write at 0x00c0000321f8 by goroutine 13:
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:385 +0x7b6
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Previous read at 0x00c0000321f8 by goroutine 12:
reflect.typedmemmove()
/usr/local/go/src/runtime/mbarrier.go:177 +0x0
reflect.packEface()
/usr/local/go/src/reflect/value.go:119 +0x103
reflect.valueInterface()
/usr/local/go/src/reflect/value.go:1033 +0x16f
fmt.(*pp).printValue()
/usr/local/go/src/reflect/value.go:1003 +0x38f7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:695 +0xe05
github.com/stretchr/testify/mock.(*Mock).methodWasCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:534 +0x202
github.com/stretchr/testify/mock.(*Mock).AssertExpectations()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:454 +0x956
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.newCommand.func1()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:30 +0xff
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:139 +0x6ac
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 13 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 12 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
Sometimes it has 5 data races, which makes the tests fail: https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/589554539
Failed output
=== RUN TestCommand_Run/command_times_out
==================
WARNING: DATA RACE
Write at 0x00c0000325e8 by goroutine 21:
sync/atomic.CompareAndSwapInt32()
/usr/local/go/src/runtime/race_amd64.s:293 +0xb
sync.(*Mutex).Lock()
/usr/local/go/src/sync/mutex.go:74 +0x49
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:346 +0x61
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Previous read at 0x00c0000325e8 by goroutine 20:
reflect.typedmemmove()
/usr/local/go/src/runtime/mbarrier.go:177 +0x0
reflect.packEface()
/usr/local/go/src/reflect/value.go:119 +0x103
reflect.valueInterface()
/usr/local/go/src/reflect/value.go:1033 +0x16f
fmt.(*pp).printValue()
/usr/local/go/src/reflect/value.go:1003 +0x38f7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:687 +0xf1a
github.com/stretchr/testify/mock.(*Mock).findExpectedCall()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:269 +0x16a
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:348 +0xb3
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockKillWaiter).KillAndWait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_KillWaiter.go:14 +0xfe
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:77 +0x482
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 21 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 20 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Write at 0x00c0000325b8 by goroutine 21:
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:385 +0x7b6
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Previous read at 0x00c0000325b8 by goroutine 20:
reflect.typedmemmove()
/usr/local/go/src/runtime/mbarrier.go:177 +0x0
reflect.packEface()
/usr/local/go/src/reflect/value.go:119 +0x103
reflect.valueInterface()
/usr/local/go/src/reflect/value.go:1033 +0x16f
fmt.(*pp).printValue()
/usr/local/go/src/reflect/value.go:1003 +0x38f7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:687 +0xf1a
github.com/stretchr/testify/mock.(*Mock).findExpectedCall()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:269 +0x16a
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:348 +0xb3
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockKillWaiter).KillAndWait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_KillWaiter.go:14 +0xfe
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:77 +0x482
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 21 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 20 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c0000325e8 by goroutine 20:
fmt.(*pp).printValue()
/usr/local/go/src/reflect/value.go:982 +0x359a
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:687 +0xf1a
github.com/stretchr/testify/mock.(*Mock).findExpectedCall()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:269 +0x16a
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:348 +0xb3
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockKillWaiter).KillAndWait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_KillWaiter.go:14 +0xfe
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:77 +0x482
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Previous write at 0x00c0000325e8 by goroutine 21:
sync/atomic.CompareAndSwapInt32()
/usr/local/go/src/runtime/race_amd64.s:293 +0xb
sync.(*Mutex).Lock()
/usr/local/go/src/sync/mutex.go:74 +0x49
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:346 +0x61
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Goroutine 20 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 21 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c0004041b0 by goroutine 20:
reflect.typedmemmove()
/usr/local/go/src/runtime/mbarrier.go:177 +0x0
reflect.packEface()
/usr/local/go/src/reflect/value.go:119 +0x103
reflect.valueInterface()
/usr/local/go/src/reflect/value.go:1033 +0x16f
fmt.(*pp).printValue()
/usr/local/go/src/reflect/value.go:1003 +0x38f7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:869 +0xec7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:695 +0xe05
github.com/stretchr/testify/mock.(*Mock).findExpectedCall()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:269 +0x16a
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:348 +0xb3
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockKillWaiter).KillAndWait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_KillWaiter.go:14 +0xfe
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:77 +0x482
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Previous write at 0x00c0004041b0 by goroutine 21:
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:385 +0x775
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Goroutine 20 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 21 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c000426020 by goroutine 20:
reflect.Value.String()
/usr/local/go/src/reflect/value.go:1845 +0x5d
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:761 +0x3156
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:869 +0xec7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:869 +0xec7
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:810 +0x283f
fmt.(*pp).printValue()
/usr/local/go/src/fmt/print.go:880 +0x25da
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:716 +0x2ee
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1126 +0x912
fmt.Sprintf()
/usr/local/go/src/fmt/print.go:219 +0x73
github.com/stretchr/testify/mock.Arguments.Diff()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:695 +0xe05
github.com/stretchr/testify/mock.(*Mock).findExpectedCall()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:269 +0x16a
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:348 +0xb3
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockKillWaiter).KillAndWait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_KillWaiter.go:14 +0xfe
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:77 +0x482
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Previous write at 0x00c000426020 by goroutine 21:
github.com/stretchr/testify/assert.CallerInfo()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/assert/assertions.go:146 +0x3c3
github.com/stretchr/testify/mock.(*Mock).MethodCalled()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:385 +0x57e
github.com/stretchr/testify/mock.(*Mock).Called()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/mock/mock.go:338 +0x1e4
gitlab.com/gitlab-org/gitlab-runner/helpers/process.(*MockCommander).Wait()
/builds/gitlab-org/gitlab-runner/helpers/process/mock_Commander.go:48 +0x63
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).waitForCommand()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:86 +0x77
Goroutine 20 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:89 +0xacd
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 21 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.(*command).Run()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command.go:69 +0x1f5
gitlab.com/gitlab-org/gitlab-runner/executors/custom/command.TestCommand_Run.func4()
/builds/gitlab-org/gitlab-runner/executors/custom/command/command_test.go:127 +0x532
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
Edited by 🤖 GitLab Bot 🤖