Runner registration does not fail when config file creation cannot succeed
Summary
When /etc/gitlab-runner/
is RO, registration does not fail. Even worse, it reports success:
Runner registered successfully. Feel free to start it, but if it's running already the config should be automatically reloaded!
Steps to reproduce
- run a runner, for which
/etc/gitlab-runner
will be RO, for example-v /tmp/runner-config:/etc/gitlab-runner:ro
whendocker run
-ning the runner - run
gitlab-ci-multi-runner register
Actual behavior
Runner registered successfully. Feel free to start it, but if it's running already the config should be automatically reloaded!
Expected behavior
You should see a failure
Used GitLab Runner version
1.10.4 (b32125f8)
Edited by 🤖 GitLab Bot 🤖