You need to sign in or sign up before continuing.
Follow-up from "Handle 503 status when uploading artifacts and the object storage is unavailable"
The following discussion from !1887 (merged) should be addressed:
-
@ggeorgiev_ commented on a discussion: (+2 comments) I agree, maybe we could rename the function to something like
MakeFatalLogsPanic
?Let's do that in another issue if you agree with this approach.
The idea is to replace helpers.MakeFatalLogsPanic()
with a method like helpers.AssertLogsFatal(t, func() { cmd.Execute(nil) })
that asserts that the passed function logs a fatal error.