Skip to content

Let version sanity test check dev repos

Mark Lapierre requested to merge ml-update-version-sanity-check into master

What does this MR do and why?

Uses the source repo details from the image's version manifest to use the correct commit when checking the commit age.

Before this it would always use the commit from gitlab.com, even when the image was built from the source on dev.gitlab.org. Most of the time that was fine because the commits were the same, but sometimes the commit on dev.gitlab.org is a merge commit that only exists there (like this one), so the sanity test would fail.

Closes gitlab#363723 (closed)

How to set up and validate locally

$ export GITLAB_QA_DEV_ACCESS_TOKEN=<insert token from 1Password>
$ ./exe/gitlab-qa Test::Sanity::Version EE
...
Found commit c893f262dbd040ddb757a64b17db8a95274a4eef in recent history of gitlab/gitlab-ee on dev.gitlab.org

Test results

Tested in https://gitlab.com/gitlab-org/quality/nightly/-/merge_requests/110

Found commit 142e84ab10b7ece18573aed99547b57669200f28 in recent history of gitlab/gitlabhq on dev.gitlab.org
Found commit c893f262dbd040ddb757a64b17db8a95274a4eef in recent history of gitlab/gitlab-ee on dev.gitlab.org

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Lapierre

Merge request reports