Skip to content

Fixes `QA_IMAGE_TAG` value when set from `TOP_UPSTREAM_SOURCE_REF`

Sanad Liaquat requested to merge shl-consider-upstream-project into master

What does this MR do and why?

Describe in detail what your merge request does and why.

  • Only use the value of TOP_UPSTREAM_SOURCE_REF for setting QA_IMAGE when TOP_UPSTREAM_SOURCE_PROJECT is gitlab-org/gitlab. See this Slack message (internal link).
  • Replace \ with - in TOP_UPSTREAM_SOURCE_REF for use as QA_IMAGE_TAG. See this Slack message (internal link)
  • Convert TOP_UPSTREAM_SOURCE_REF to downcase for use as QA_IMAGE_TAG.

MRs dependent on this fix:

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sanad Liaquat

Merge request reports