Loading
Fix scenario and config names in what_tests_can_be_run.md
What does this MR do and why?
Some commands in docs/what_tests_can_be_run.md no longer work when copied, because the scenario or Omnibus config they name does not exist anymore. This MR fixes them:
- GitHub OAuth example. The example ran
gitlab-qa Test::Integration::OAuth CE/EE, but there is noTest::Integration::OAuthscenario. GitHub OAuth is now set up through thegithub_oauthOmnibus config (lib/gitlab/qa/runtime/omnibus_configurations/github_oauth.rb), so the example now usesgitlab-qa Test::Instance::Image CE|EE --omnibus-config github_oauth. - Google Cloud Storage config name. The object storage section said to pass
--omnibus-config object_storage_gcp. The config is calledobject_storage_gcs(ObjectStorageGcsinobject_storage_gcs.rb). Because the runner looks the name up withconst_get(config.camelize),object_storage_gcpfails with aNameError. GCS_BUCKET_NAMEdescription. It said "Name of the bucket set in AWS". It is the bucket in GCP.- Removed the
Test::Integration::Packagessection. The scenario was removed in !662 (merged), and thepackagesOmnibus config was removed in e13293d7 ("Remove package scenario configuration"). The section still told readers to run--omnibus-config packagesand linked to the deletedpackages.rb, so following it fails.
The Chaos section also has naming problems, but I left it alone because #691 (closed) already covers improving that documentation.
Screenshots or screen recordings
Not applicable (documentation only).
How to set up and validate locally
- Check the available Omnibus configs:
ls lib/gitlab/qa/runtime/omnibus_configurations/. It listsgithub_oauth.rbandobject_storage_gcs.rb, and noobject_storage_gcp.rborpackages.rb. - Check that there is no OAuth or Packages integration scenario:
ls lib/gitlab/qa/scenario/test/integration/. - See how the config name is resolved in
lib/gitlab/qa/runner.rb(Runtime::OmnibusConfigurations.const_get(config.camelize)):object_storage_gcsresolves toObjectStorageGcs, whileobject_storage_gcpwould look forObjectStorageGcp, which does not exist.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- Commits include
Changelog:trailer - I have evaluated the MR acceptance checklist for this MR.
This contribution was prepared with the help of an AI assistant. I reviewed the changes and take responsibility for them.