Fix reconfigure_log_file exception

Jay McCurerequested to merge
jmc-fix-teardown-log-error into master

What does this MR do and why?

Resolves #737 (closed)

get_reconfigure_log_file_from_artefact is only a method of the gitlab module, but it is referenced in the Base class so when a different child class references this in #instance_no_teardown a method missing error occurs. This change ensures returns nil for get_reconfigure_log_file_from_artefact for non-gitlab components

Before: https://gitlab.com/gitlab-org/gitlab/-/jobs/10018142871#L193 (method missing exception) After: https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/10053108959#L1066 (can see the actual error - had to create a test MR to invoke an error) https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/10084116076

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports