Skip to content

Allow masking secrets for base component

Jay McCure requested to merge jmc-hide-aigw-keys into master

What does this MR do and why?

Moves secrets to base component so other components can utilise mask_secrets when doing docker#run. Additionally hides the two test signing keys used by the AiGateway component. Although these keys are safe to be shared, they have caused confusion (SIRT incident raised) when they were detected in the logs.

How to set up and validate

GitLab test MR using this branch -> gitlab!162801 (closed)

Keys not being printed to logs: https://gitlab.com/gitlab-org/gitlab/-/jobs/7588730343#L362 (AIGW_SELF_SIGNED_JWT__VALIDATION_KEY and AIGW_SELF_SIGNED_JWT__SIGNING_KEY)

Regression checks: GITLAB_QA_USER_AGENT \ QA_EE_ACTIVATION_CODE: https://gitlab.com/gitlab-org/gitlab/-/jobs/7588730343#L379 / https://gitlab.com/gitlab-org/gitlab/-/jobs/7588730295#L375

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports