Raise error with message when pervious minor version not found
What does this MR do and why?
Describe in detail what your merge request does and why.
Closes gitlab#473141 (closed)
There could be situations where a minor version is not yet published to docker hub. In such cases raise an error with a message.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
Commits include Changelog:
trailer -
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %17.3
added QA Quality teamTest and Tools Infrastructure labels
assigned to @sliaquat
- Resolved by Andrejs Cunskis
If a pervious version is not available we could have gone with a version 2 levels earlier. For example, if current version is
17.3.0-pre
and17.2.0
is not yet published, we could go with17.1.1
.However, I decided against that since that is not the purpose of the test. It is supposed to test upgrade from
17.2.0
and if it is not there yet, do not proceed.
marked the checklist item Commits include
Changelog:
trailer as completed- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@sliaquat
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added 1 commit
- c81e172b - Raise error with message when pervious minor verison not found
added maintenancerefactor typemaintenance labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @splattael
(UTC+2, 3 hours behind
@sliaquat
)@chloeliu
(UTC-7, 12 hours behind
@sliaquat
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @acunskis
mentioned in issue gitlab-org/quality/pipeline-triage#280 (closed)
mentioned in issue gitlab#473141 (closed)
added ttisupport-request label
mentioned in commit 8ecdd7e1