Allow configurable docker network with default

What does this MR do and why?

Describe in detail what your merge request does and why.

• Allow the Docker Network to be overridden with QA_DOCKER_NETWORK.
• Passthrough the QA_DOCKER_NETWORK environment variable.
• Alphabetically sort the Runtime::Env::ENV_VARIABLES constant.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

QA_DOCKER_NETWORK=local gitlab-qa Test::Instance::Any ...

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• Commits include Changelog: trailer
• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %17.1

added QA Quality Sub-DepartmentTest Platform maintenancerefactor teamTest and Tools Infrastructure typemaintenance labels

marked the checklist item Commits include Changelog: trailer as completed

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Reviewer	Maintainer
@willmeek (UTC+1, 5 hours ahead of @ddavison)	@chloeliu (UTC-7, 3 hours behind @ddavison)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 11c52dc1 - Allow configurable docker network with default

Compare with previous version

assigned to @ddavison

assigned to @chloeliu

added workflowin dev label

added 1 commit

• e7a041e6 - Restore GITLAB_LICENSE_MODE to test

Compare with previous version

Thanks for doing this change , perhaps this one also? https://gitlab.com/gitlab-org/gitlab-qa/-/blob/dj-add-docker-network-override/lib/gitlab/qa/component/gitaly_cluster.rb#L19

added 1 commit

• e9c50e82 - Allow configurable docker network with default

Compare with previous version

resolved all threads

added 1 commit

• 3904438e - Allow configurable docker network with default

Compare with previous version

@ddavison Just a gentle nudge - do you think the MR is ready for review? Thank you!

added 1 commit

• 7e7ffb64 - Allow configurable docker network with default

Compare with previous version

added 1 commit

• 6be0838a - Allow configurable docker network with default

Compare with previous version

marked this merge request as draft

changed the description

@sliaquat - would you perhaps have context into why this job would be failing?

It's calling Runtime::Env.release, which is passed in through GitLab QA - this MR breaks this test for some reason

marked this merge request as ready

unassigned @chloeliu

requested review from @sliaquat

added workflowin review label and removed workflowin dev label

requested review from @chloeliu

approved this merge request

removed review request for @chloeliu

requested review from @chloeliu and removed review request for @sliaquat

resolved all threads

approved this merge request

unapproved this merge request

merged

mentioned in commit de097b18

resolved all threads