Skip to content

Update activesupport dependency and fix logger

Mark Lapierre requested to merge ml-fix-logger into master

What does this MR do and why?

Updates activesupport dependency to 7.1.2 and updates Gitlab::QA::TestLogger to use the new ActiveSupport::BroadcastLogger.

Fixes a NoMethodError error that occurs when an older version of activesupport is used. This became possible after support for 7.2 was added in c91ef8df. E.g.: https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/12496862#L36

/builds/gitlab-org/quality/staging/.gems/gems/gitlab-qa-13.2.0/lib/gitlab/qa/test_logger.rb:32:in `logger': undefined method `broadcast' for ActiveSupport::Logger:Class (NoMethodError)

How to set up and validate locally

Install the bundle, run a command, and check that logging happens. E.g.:

bundle install
./exe/gitlab-qa Test::Instance::Any EE http://gdk.test

...

[Jan 15 2024 16:12:15 AEDT (Gitlab QA)] INFO  -- Shell command: `docker pull -q gitlab/gitlab-ee-qa:nightly`

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Lapierre

Merge request reports