Use TLS in OAuth tests
What does this MR do and why?
Use TLS in OAuth tests
This will be required for using same orchestration for testing other OAuth providers such as Google and Facebook that require TLS.
This will also fix gitlab#415323 (closed)
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
assigned to @sliaquat
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer Désirée Chevalier (
@dchevalier2
) (UTC-4, 9 hours behind@sliaquat
)Mark Lapierre (
@mlapierre
) (UTC+10, 5 hours ahead of@sliaquat
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitlab-org/quality/pipeline-triage#202 (closed)
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@sliaquat - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
- Resolved by Sanad Liaquat
Testing here: gitlab!123621 (closed)
Passed: https://gitlab.com/gitlab-org/gitlab/-/jobs/4478249624
Edited by Sanad Liaquat
added maintenancerefactor typemaintenance labels
mentioned in issue gitlab#415323 (closed)
- Resolved by Mark Lapierre
@dchevalier2 Could you review this minor change? Thanks.
requested review from @dchevalier2
- Resolved by Mark Lapierre
@mlapierre Could you do the maintainer review? (Asking maintainer review before reviewer approval to fast-track this as it is needed to get the OAuth job passing and I will be on PTO from Monday for two weeks).
requested review from @mlapierre
- Resolved by Mark Lapierre
removed review request for @dchevalier2
mentioned in commit 9f144c57
mentioned in issue gitlab-org/quality/pipeline-triage#203 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#204 (closed)