QA products in resources should be optional
This is the second time this comes to my mind, which is: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18696#note_71903592
The thing is that populating products could take some time, and we might not be interested in those products in different test cases.
Like here, the
name
product, isn't it just thebranch_name
we supply before? How could they be different? One reason to get it would be verifying that the changes were passed through and it's showing the right text on the view, and that's exactly the previous test is doing.It makes sense in that case, just that it's not quite re-useful because we don't want those products in other test cases.
I tried to make them optional when this came to my mind the first time, because those products were data dependent and in my another test case, they just broke. In the end I either removed them or fixed those products I was not using, which feels pretty wrong and wasting time.
I didn't make them optional already because it's not trivial to come up an API given current status. We should still make them optional in the future.