Skip to content

Make the flags logging dynamic

Kassio Borges requested to merge kassio/dynamic-flag-logging into master

What does this MR do?

While debugging some behaviors locally, I noticed that not all the flags/options were being logged in the startup.

This MR aims to fix that by adding a test that fails if a new flag/option is either not logged or marked as nonLoggableFlags.

keys that were missing

  • "gitlab-cache-cleanup"
  • "gitlab-cache-expiry"
  • "gitlab-cache-refresh"
  • "gitlab-client-http-timeout"
  • "gitlab-client-jwt-expiry"
  • "gitlab-retrieval-interval"
  • "gitlab-retrieval-retries"
  • "gitlab-retrieval-timeout"
  • "listen-proxy"
  • "max-uri-length"
  • "server-shutdown-timeout"
  • "server-write-timeout"
  • "zip-http-client-timeout"
  • "zip-open-timeout"

TODO

Edited by Kassio Borges

Merge request reports