Skip to content

Fix data race with lookup paths

Stan Hu requested to merge sh-fix-data-race-lookup into master

What does this MR do?

Since the API response for domains is cached, it's possible that multiple clients for the same host may cause a data race when sorting the lookup paths. To ensure this doesn't happen, we sort the lookup paths once before we cache it.

Relates to #646 (closed)

See investigation details in https://gitlab.com/gitlab-org/gitlab-pages/-/issues/690#note_1036454543.

TODO

Edited by Stan Hu

Merge request reports