Skip to content

test: check for errors in acme tests before passing the body

feistel requested to merge feistel/gitlab-pages:fix/test-acme-sigsev into master

What does this MR do?

I got a SIGSEV while working on another MR and noticed we're passing rsp.Body without checking rsp for nullness.

This MR move rsp.Body.Close() after require.NoError to avoid the SIGSEV and correctly report the error using the assertion.

testhelper is also removed in this situation so that the body is closed as soon as possible and can be reused in the next iteration.

TODO

Edited by feistel

Merge request reports