Skip to content

fix: serve 404 if ctx is canceled while resolving a domain

feistel requested to merge feistel/gitlab-pages:fix/routing-502 into master

What does this MR do?

If the ctx is canceled while resolving a domain we should serve a 404 (this is consistent with other context.Canceled handling).

Note: TestSlowRequest is not able to catch this because it succeed thanks to the 404 returned by the ping request (see func WaitUntilRequestSucceed).

TODO

Merge request reports