Skip to content

Draft: replace defer with t.Cleanup in tests

Yiğithan Kardaş requested to merge (removed):master into master

What does this MR do?

I am planning to solve this issue in at least 2 MR's. This MR specifically focuses on acceptance tests. I have changed the code so that all Body's will be closed using testhelpers.Close() function. I have managed to pass all the tests on local but somehow, pipeline has failed. You can see the error "testhelpers.Close is undefined" which is kind of weird because I have imported gitlab.com/gitlab-org/gitlab-pages/internal/testhelpers on all the necessary files. I also marked this MR as 'Draft' because I need to implement unit tests as well. So I need your review.

Related to #607 (closed)

TODO

Edited by Yiğithan Kardaş

Merge request reports