test: migrate to assertions using modern error checking

What does this MR do?

Migrate to assertions using modern error checking (require.ErrorIs).

As a bonus this should fix a bunch of misuse of require.Equal: swapping the expected/got arguments.

TODO

• I added the Changelog trailer (e.g. Changelog: added) to the commits that need to be included in the changelog
• I added unit tests or they are not required
• I added acceptance tests or they are not required
• I added documentation (or it's not required)
• I followed code review guidelines
• I followed Go Style guidelines