Skip to content

fix: catch io.copy errors when serving content

feistel requested to merge feistel/gitlab-pages:fix/catch-serve-errors into master

What does this MR do?

While investigating https://gitlab.com/gitlab-org/gitlab-pages/-/issues/690 I have found a bunch of errors being ignored around the codebase. This is problematic, especially this case: the error is ignored and a 200 OK status is returned.

This is vendored code so there's a redundant if to reduce the diff with upstream code.

TODO

Edited by feistel

Merge request reports