Skip to content

refactor: stop passing file descriptors around and use net.Listen directly

feistel requested to merge feistel/gitlab-pages:remove/file-descriptors into master

What does this MR do?

Using file descriptors directly is really fragile and prone to error, some of those shortcomings were outlined in #114 (closed). Since we moved away from the daemon-like architecture (see #133 (closed)) we don't need to pass fd around anymore.

TODO

Merge request reports