Skip to content

Ensure that we always close GitLab API response body

Grzegorz Bizon requested to merge fix/gb/gitlab-api-reuse-http-connections into master

Description

This change is important because in case of receiving a JSON payload from GitLab API that is invalid, and is larger than 512, deserializer will stop reading it after 512 bytes and will not close the reader.

This will result in HTTP connection not being reused.

This merge request ensures that we always read reasponse body until EOF and that we close the reader afterwards.

Credits go to people who managed to help with investigating this bug @igorwwwwwwwwwwwwwwwwwwww @ayufan @jarv.

/cc @jmeshell

Merge request reports