Skip to content

pages for subgroups

Alessio Caiazza requested to merge ac-subgroups into master

closes gitlab-org/gitlab-ce#30548

Requires https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23505 for configuring CNAME and TLS

Proposed changes

the lookup part is straightforward. domain.D is refactored extracting domain.group out of it, there we have a recursive lookup group.digProjectWithSubpath(parentPath string, keys []string) (*project, string, string).

project mapping can be summarized with this changes:

  • readProject now has a parent parameter which is the path to the project within the first-level group.
  • during readProject if we can't find the public folder, then we scan for subgroups recursively
  • when we perform updateGroupDomain at the end, we split the projectpath and create all the needed subgroups

TODO

  • self review
  • testing CNAME in subgroups
Edited by Alessio Caiazza

Merge request reports