Skip to content

Allow the maximum connection concurrency to be set

Nick Thomas requested to merge (removed):172-runtime-thread-limit into master

Currently, GitLab Pages will happily accept() an unlimited number of connections. This can cause problems, up to and including running out of OS threads as 10,000 connection are made, then all block on the read() system call, causing the whole process to die.

To avoid this, allow the maximum connection concurrency to be set. This limit applies to the sum of connections made to the GitLab Pages -listen-http, listen-https and -listen-proxy servers. Setting this to lower than ~10,000 allows the resource exhaustion leading to a complete process failure to be avoided.

Related to #172 (closed)

Edited by Nick Thomas

Merge request reports