refactor: rename handler receiver to something more accurate

The following discussion from !765 (merged) should be addressed:

• @jaime started a discussion:

  nit (non-blocking): a * Handlers is probably a leftover from when the middleware functions were moved out of app.go. The change requires more refactoring so let's also follow-up

  func (h *Handlers) HandleArtifactRequest(w http.ResponseWriter, r *http.Request) bool {

added Category:Pages Seeking community contributions groupeditor [DEPRECATED] maintenancerefactor typemaintenance labels

@jaime thanks for adding the Seeking community contributions label!

This issue's description does not seem to have a section for "Implementation Guide". Please consider adding one, because it makes a big difference for contributors. This section can be brief but must have clear technical guidance, like:

• Hints on lines of code which may need changing
• Hints on similar code/patterns that can be leveraged
• Suggestions for test coverage
• Ideas for breaking up the merge requests into iterative chunks

Setting label(s) devopscreate sectiondev based on ~"group::editor".

added devopscreate sectiondev labels

added Hacktoberfest label

added groupknowledge label and removed groupeditor [DEPRECATED] label

added devopsplan label and removed devopscreate label

changed milestone to %Backlog

added backend golang labels

Currently all the receivers of type Handlers are defined as func (a *Handlers) funcName.

It is usually a common thing to name the receiver as a short hand of the type it's being attached to. So the ask here is to rename func (a *Handlers) which used to belong to type App, to func (h *Handlers) that belong to type Handlers.

cc @ngala

@jaime Thank you for your response. So if I understand this correctly, it is just a receiver name change from a to h.

The issue description also mentions:

The change requires more refactoring

@ngala well that was in the context of !765 (merged) which was merged 2+ years ago. I think things have changed by now so maybe it's not a big change anymore.

set weight to 1

added quick win quick winfirst-time contributor labels

@ngala thanks for adding the quick win label!

However, it appears that this issue does not meet all of the required criteria for the label to be applied so it has been automatically removed.

You can refer to the criteria for quick win issues documentation for an up-to-date list of the requirements.

This message was generated automatically. You're welcome to improve it.

added automation:quick-win-removed label and removed quick win label

I can check this!

@max-wittig Thank you. I will assign this issue to you.

mentioned in commit gitlab-community/gitlab-pages@78544c3f

mentioned in merge request !1072 (merged)

mentioned in commit gitlab-community/gitlab-pages@dda42f7c

added workflowin dev label

assigned to @max-wittig

changed milestone to %17.6

added Community contribution label

added workflowin review label and removed workflowin dev label

mentioned in commit d9954afc

closed with merge request !1072 (merged)

added workflowcomplete label and removed workflowin review label

removed Seeking community contributions label