Improve zip cache refreshing for the same domain
We open a bunch of archives each minute: https://prometheus-app.gprd.gitlab.net/graph?g0.range_input=1h&g0.expr=increase(gitlab_pages_zip_opened%5B5m%5D)&g0.tab=0
From slack: https://gitlab.slack.com/archives/C1BSEQ138/p1602144418115300
kamil Oct 8th at 7:06 PM
@jaime I think we are done with LRU for time being. Maybe next get archive refresh to be working?
4 replies
kamil 5 days ago
Looking at this graph it appears that we open a bunch of archives each minute: https://prometheus-app.gprd.gitlab.net/graph?g0.range_input=1h&g0.expr=increase(gitlab_pages_zip_opened%5B5m%5D)&g0.tab=0
jaime 1 day ago
do you mean we’re refreshing too often?
kamil 22 hours ago
Yes, we each time we refresh the domain via API a new URL is being returned due to changed auth params. This means that we reload each accessed archive every minute. (edited)
kamil 22 hours ago
Due to caching, holding 2-3 archives for a given domain at a single time.
Edited by Jaime Martinez