Remove `gitlab-server` fallback to `auth-server` and `artifacts server`
Currently auth-server
and artifacts-server
may be used instead of gitlab-server
command line flag. That was done for a seamless upgrade.
Deprecation was announced, so we can just remove it in %14.0
From @igorwwwwwwwwwwwwwwwwwwww's comment !270 (comment 334218639) :
Alternatively, I think it might be good to remove this fallback logic.
From an operational perspective, I found it very surprising that
gitlab-server
inherits from both auth server as well as artifacts server.I would find the inverse much more intuitive. But even having to specify all the params would be acceptable.
So if we can verify that the main consumers of this (probably just omnibus?) are always specifying
gitlab-server
explicitly, it may be worth simply requiring it to be specified without fallback.
We need to:
-
Mark auth-server as deprecate in Omnibus(might be already done) -
Make a release deprecation post. draft:
We're changing the behaviour of some configuration options of GitLab Pages. If you run GitLab Pages via Omnibus based package, no action required. Otherwise, make sure to set [`gitlab-server` parameter and remove `auth-server`](https://docs.gitlab.com/ee/administration/pages/).
Later we may consider removing artifacts-server
and use gitlab-server
(or better: new parameter introduced in !276 (merged)) and appending path.