Feature flag: FF_RATE_LIMITER_CLOSE_CONNECTION
Summary
This issue is to rollout https://gitlab.com/gitlab-org/gitlab/-/issues/438367+ on production, that is currently behind the FF_RATE_LIMITER_CLOSE_CONNECTION
feature flag.
Expectations
What are we expecting to happen?
Terminate connection on 429 on the HTTP rate-limiter. Here we are adding Connection: close
header in the request to notify client to close the connection.
What might happen if this goes wrong?
HTTP rate-limiter will be affected and connection close will not work. In that case, we can revert this MR: !949 (merged)
Rollout Steps
-
Temporarily enable with environment variable: Prod: Enable FF_RATE_LIMITER_CLOSE_CONNECTION (gitlab-com/gl-infra/k8s-workloads/gitlab-com!3402 - merged) -
Enable by default (optional): Link to the MR -
Remove the feature flag: Link to the MR
Rollback Considerations/Events
-
Disabling with environment variable: Link to the MR -
Remove the feature flag: Link to the MR
Edited by Naman Jagdish Gala