Skip to content

Make `ActionContorller::Parameters` serializable for sidekiq jobs

Peter Leitzen requested to merge pl-serialize-ac-parameters into master

What does this MR do?

Prior this commit passing parameters (ActionController::Parameters) from a controller to sidekiq jobs failed with

ActiveJob::SerializationError: Unsupported argument type: ActionController::Parameters

This is a port of https://github.com/rails/rails/commit/945fdd76925c9f615bf016717c4c8db2b2955357#diff-fc90ec41ef75be8b2259526fe1a8b663d included in Rails 6.0.

We have patch (🐵) ActiveJob::Arguments but also need to make sure that this patch is removed starting with Rails 6.0.

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/9552

Does this MR meet the acceptance criteria?

Edited by Peter Leitzen

Merge request reports