Make `ActionContorller::Parameters` serializable for sidekiq jobs
What does this MR do?
Prior this commit passing parameters (ActionController::Parameters
)
from a controller to sidekiq jobs failed with
ActiveJob::SerializationError: Unsupported argument type: ActionController::Parameters
This is a port of https://github.com/rails/rails/commit/945fdd76925c9f615bf016717c4c8db2b2955357#diff-fc90ec41ef75be8b2259526fe1a8b663d included in Rails 6.0.
We have patch (ActiveJob::Arguments
but also need to make sure that this patch is removed starting with Rails 6.0.
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ee/issues/9552
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Edited by Peter Leitzen