Skip to content

Add id to modal.vue to support data-toggle="modal"

Inactive Account requested to merge winh-modal-target-id into master

What does this MR do?

Add id to modal.vue props to support using the modal via data attributes.

Additionally

  • renames toggle event to cancel
  • forwards original event to allow event.stopPropagation()
  • converts delete account modal to data attributes

Why was this MR needed?

It was not possible to use the Bootstrap modal as intended.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Frontend

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/28849

fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/41584

Edited by Filipa Lacerda

Merge request reports