Skip to content

Fix bug where clicking on the link icon on a file would result in "#Lundefined" in the URL

Stan Hu requested to merge stanhu/gitlab-ce:fix-line-highlighter-link-click into master

Clicking on the link icon next to a line in the file highlighter results in the URL with "#Lundefined" at the end. It appears that e.target is the fa-link icon instead of the a link. This MR makes it so the closest a link is used to retrieve the line number.

This fix seems to resolve #2002 (closed) for me, but perhaps there is a better way. I'm not sure why the e.data would be nil:

`$('#tree-content-holder').on 'mousedown', 'a[data-line-number]', @clickHandler`

Closes #2002 (closed)

Merge request reports