Fix issues mentioned but not closed for JIRA
What does this MR do?
When using an external issue tracker, we would show issues that were closed by an MR as both:
- Accepting this merge request will close issue X.
- Issue X is mentioned but will not be closed.
Are there points in the code the reviewer needs to double check?
I feel a little uncertain about overriding ExternalIssue#hash
, but it seems the simplest solution.
Why was this MR needed?
The bug was really dumb.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/26028.
Merge request reports
Activity
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
@smcgivern I think that it's the right approach. http://ruby-doc.org/core-2.4.0/Object.html#method-i-eql-3F says that:
Subclasses normally continue this tradition by aliasing
eql?
to their overridden==
methodI think that it's totally fine to override
eql?
andhash
here.I left two minor comments and everything else looks good to me.
assigned to @smcgivern
@adamniedzielski thanks, updated!
assigned to @adamniedzielski
@smcgivern Everything looks fine to me now.
assigned to @smcgivern
enabled an automatic merge when the pipeline for 5ce3845f succeeds
@smcgivern Is there any chance, that this could go into version 8.17.3?
@jannickfahlbusch I'm afraid not, it will be in 9.0