Minor refactoring of Uploaders
Extracted from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8893
- Moves a duplicate
file_storage?
definition into the commonGitlabUploader
ancestor. - Get the
uploads
base directory from a class method rather than hard-coding it where it's needed. This will be used in a subsequent MR to store Uploads in the database. - Improves the specs for uploaders.