Resolve "Test compiling frontend assets for production in CI"
What does this MR do?
Adds a new rake gitlab:assets:compile
step to GitLab's CI config which tests compiling production assets and runs webpack-bundle-analyzer
on the result. Bundle analyzer results are saved to webpack-report
directory and published to gitlab pages.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
We weren't testing our production asset compilation step outside of omnibus-gitlab
so errors in our webpack.config.js
file or our package.json
could go unnoticed for a long time.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added - Tests
-
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #28450 (closed)
Merge request reports
Activity
added 1 commit
- 98e0363a - add production asset compile step to CI config
added 1 commit
- 29838756 - add production asset compile step to CI config
added 8 commits
-
29838756...88152949 - 6 commits from branch
master
- 593e5789 - add production asset compile step to CI config
- b659f3fe - wip
-
29838756...88152949 - 6 commits from branch
added 2 commits
added 2 commits
added 3 commits
added 1 commit
- 9a11acab - add webpack bundle analyzer to production output
mentioned in commit 1c4b8c1a
marked the task Changelog entry added as completed
assigned to @jschatz1
mentioned in merge request !9240 (closed)
@jschatz1 this is ready for review... you can find the output of the webpack report within the artifacts in this build file: https://gitlab.com/gitlab-org/gitlab-ce/builds/10909084
mentioned in commit dblessing/gitlab-ce@62829b6b