Skip to content
Snippets Groups Projects

API: Make subscription API more RESTfuL

Merged Robert Schilling requested to merge api-subscription-restful into master

What does this MR do?

Only use POST requests to subscribe and unsubscribe.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/28327

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @razer6 thanks! The code looks good to me, one comment about the docs.

  • added 1 commit

    Compare with previous version

  • Robert Schilling resolved all discussions

    resolved all discussions

  • Author Developer

    @smcgivern Thanks for the review. I updated the docs.

  • Sean McGivern enabled an automatic merge when the pipeline for 7e6da2ba succeeds

    enabled an automatic merge when the pipeline for 7e6da2ba succeeds

  • assigned to @razer6

  • Robert Schilling added 2 commits

    added 2 commits

    • b0d55780 - API: Make subscription API more RESTfuL
    • d79dd50d - Update documentation

    Compare with previous version

  • Author Developer

    @smcgivern Finally, the specs are passing locally :)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading