Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1
    • Merge requests 1
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !9123

Merged
Created Feb 10, 2017 by Mike Greiling@mikegreiling🔴Maintainer4 of 6 tasks completed4/6 tasks

Remove window-binding hack with imports-loader

  • Overview 7
  • Commits 3
  • Pipelines 5
  • Changes 100+

What does this MR do?

Removes a hack that wraps every script in (function(){ ... }).call(window); for the sake of preserving sprockets behavior in scripts which take for granted that this is the same thing as window. Instead the scripts which rely on this behavior have been modified directly.

Are there points in the code the reviewer needs to double check?

Make sure nothing has broken.

Why was this MR needed?

The imports-loader hack throws off sourcemaps and has some odd side-effects in babel like not allowing import/export to function properly.

Does this MR meet the acceptance criteria?

  • Changelog entry added
  • Tests
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

#27486 (moved)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: remove-imports-loader-window-bind