Skip to content

Fix form response errors not shown for create label dropdown.

Tom Koole requested to merge kewleus/gitlab-ce:27287-label-dropdown-error-messages into master

What does this MR do?

  • Fix bug where form response errors were not displayed in create new label dropdown.
  • Humanize the key of the response error
  • Add rspec to validate error is shown if title is taken
  • I also fixed a typo in another test description.

Are there points in the code the reviewer needs to double check?

  • First time writing a test, it passed for me, but please validate it's checking the right things.
  • Any feedback welcome

Why was this MR needed?

  • No feedback presented when there's an error creating a label

Screenshots (if relevant)

new error

What are the relevant issue numbers?

#27287 (closed) - Will be submitting a new merge request soon for the new behaviour requested in issue. Keeping the bug fix separate for minimal MR.

Conclusion

First MR, feedback or criticism welcome.

Merge request reports