Fix rendering pipelines for a new merge request
What does this MR do?
This MR fixes a bug with invalid pipelines API call, which leads to raising an exception.
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Added tests for this feature/bug
What are the relevant issue numbers?
See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8844#note_22930365
Merge request reports
Activity
added 1 commit
- 25c1f051 - Fix rendering pipelines for a new merge request
added 1 commit
- 1c73b764 - Add feature spec for a new merge request with pipeline
added 1 commit
- 5d25871c - Add Changelog entry for new merge request pipelines fix
@ruben @felipe_artur @selfup FYI - we'll need this before tagging
8.17
Edited by James Lopezmarked the task Changelog entry added as completed
- Resolved by Kamil Trzciński
- Resolved by Filipa Lacerda
mentioned in merge request !8844 (merged)
added 1 commit
- 3ea1f91e - Fix merge request controller specs for new action
@grzesiek I pushed a commit that fixes some related broken tests. //cc @mikegreiling
mentioned in merge request !9038 (merged)
changed milestone to %8.17
@jameslopez It should! But not sure which endboss is available now. /cc @rspeicher @rymai @ayufan
- Resolved by Filipa Lacerda
@ayufan can you please review this? :)
assigned to @ayufan
The frontend portions LGTM
I committed a quick fix for another broken frontend test which @filipa can review for me. After that it should be ready for merge.
Thank you @mikegreiling for this fixes!
it LGTM! :)I believe Frontend is good to go! :)
Make sure if the 8.17-rc1 stable branch has already been made that we ~"Pick into Stable" for this one. I don't want broken frontend tests going out in this release. I also have !9038 (merged) waiting to go in which depends on this being merged first.
added 1 commit
- bf6a0e47 - Remove changelog entry; Changes after review
@fatihacet can you please review? Thank you!
Backend changes were already reviewed :)
assigned to @fatihacet
enabled an automatic merge when the pipeline for bf6a0e47 succeeds
Enabled auto merge, thanks @grzesiek @filipa and @mikegreiling
mentioned in issue #27252 (closed)
enabled an automatic merge when the pipeline for d410c937 succeeds
mentioned in commit 71c80375
- Resolved by Rémy Coutable
mentioned in issue #27866 (closed)