Skip to content
Snippets Groups Projects

Fix rendering pipelines for a new merge request

Merged Grzegorz Bizon requested to merge fix/gb/invalid-new-merge-request-api into master
All threads resolved!

What does this MR do?

This MR fixes a bug with invalid pipelines API call, which leads to raising an exception.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8844#note_22930365

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • edebf538 - Update _pipelines.html.haml

    Compare with previous version

  • Filipa Lacerda mentioned in merge request !8844 (merged)

    mentioned in merge request !8844 (merged)

  • Filipa Lacerda added 1 commit

    added 1 commit

    • 1d0820c7 - Fix broken specs from the Frontend side

    Compare with previous version

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 3ea1f91e - Fix merge request controller specs for new action

    Compare with previous version

  • @grzesiek I pushed a commit that fixes some related broken tests. //cc @mikegreiling

  • Mike Greiling mentioned in merge request !9038 (merged)

    mentioned in merge request !9038 (merged)

  • @grzesiek @filipa should this MR be assigned to someone?

  • James Lopez changed milestone to %8.17

    changed milestone to %8.17

  • Author Maintainer

    @jameslopez It should! But not sure which endboss is available now. /cc @rspeicher @rymai @ayufan

  • @ayufan can you please review this? :)

  • assigned to @ayufan

  • Mike Greiling added 1 commit

    added 1 commit

    Compare with previous version

  • The frontend portions LGTM :ok_hand:

    I committed a quick fix for another broken frontend test which @filipa can review for me. After that it should be ready for merge.

  • Thank you @mikegreiling for this fixes! :green_heart: it LGTM! :)

    I believe Frontend is good to go! :)

  • Make sure if the 8.17-rc1 stable branch has already been made that we ~"Pick into Stable" for this one. I don't want broken frontend tests going out in this release. I also have !9038 (merged) waiting to go in which depends on this being merged first.

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Filipa Lacerda added 1 commit

    added 1 commit

    • bf6a0e47 - Remove changelog entry; Changes after review

    Compare with previous version

  • @fatihacet can you please review? Thank you!

    Backend changes were already reviewed :)

  • Fatih Acet enabled an automatic merge when the pipeline for bf6a0e47 succeeds

    enabled an automatic merge when the pipeline for bf6a0e47 succeeds

  • Enabled auto merge, thanks @grzesiek @filipa and @mikegreiling :thumbsup: :thumbsup: :thumbsup:

  • mentioned in issue #27252 (closed)

  • Mike Greiling added 1 commit

    added 1 commit

    Compare with previous version

  • Fatih Acet enabled an automatic merge when the pipeline for d410c937 succeeds

    enabled an automatic merge when the pipeline for d410c937 succeeds

  • merged

  • Fatih Acet mentioned in commit 71c80375

    mentioned in commit 71c80375

  • Rémy Coutable
  • Grzegorz Bizon resolved all discussions

    resolved all discussions

  • mentioned in issue #27866 (closed)

  • Rémy Coutable resolved all discussions

    resolved all discussions

  • Please register or sign in to reply
    Loading