Limit level of nesting for groups
What does this MR do?
Limit level of nesting to 20
Are there points in the code the reviewer needs to double check?
no
Why was this MR needed?
To prevent overuse of the feature. GitLab UI cant display infinite level of nesting anyway. The number 20 was taken based on maximum nesting level of Android repo (15) + some extra backup
Does this MR meet the acceptance criteria?
-
Changelog entry addednot needed since feature not released - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
changed milestone to %9.0
added 358 commits
-
a665c120...99fceff4 - 357 commits from branch
master
- 0289ca2e - Limit level of nesting for groups
-
a665c120...99fceff4 - 357 commits from branch
mentioned in issue #2772 (closed)
marked the task Conform by the merge request performance guides as completed
marked the task Conform by the style guides as completed
marked the task Squashed related commits together as completed
@DouweM please review
assigned to @DouweM
- Resolved by Dmytro Zaporozhets (DZ)
- Resolved by Dmytro Zaporozhets (DZ)
- Resolved by Dmytro Zaporozhets (DZ)
assigned to @dzaporozhets
@DouweM should be better now!
assigned to @DouweM
mentioned in commit 7fa767fe
The number 20 was taken based on maximum nesting level of Android repo (15) + some extra backup
@dzaporozhets by Android repo you mean the official Android project repository? Do you have a link for this? Thanks
@pedroms sure, check this out https://android.googlesource.com/
@dzaporozhets thanks!