Resolve "Cannot login with 2fa"
What does this MR do?
Fixes an issue with ldap users using 2fa and u2f auth.
Currently the u2f code is called when the
data-page attribute value is
From a gif on #27047 (closed), I can see that for ldap users, the
data-page attribute value is not
sessions:create and is instead
omniauth_callbacks:...(something about ldap).
data-page value is returned from the
body_data_page method. Seeing as I have no experience with
devise, I have no idea all of the possible return values could be for the login page.
I'm not happy with this proposal.
- It messes up the already messy dispatcher.
- It will query for
.js-login-pagefor every page as long as
This isn't application exploding stuff, but the ideal fix here would be to know exactly all of the possible
namespace:controller_name:action_name combinations for the devise login to use the dispatcher
case statement, rather than querying this DOM class.
Are there points in the code the reviewer needs to double check?
Does this even fix it? Is this
devise.html.haml layout used for every possible login screen? If not, this will still break for a certain configuration.
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
- Changelog entry added
- Documentation created/updated
- API support added
- Added for this feature/bug
- All builds are passing
- Conform by the merge request performance guides
- Conform by the style guides
Branch has no merge conflicts with
master(if it does - rebase it please)
- Squashed related commits together
What are the relevant issue numbers?
Closes #27047 (closed)