better UI fix - simple solution - pipelines#index mini_graph in Vue
What does this MR do?
Enables a user to make multiple calls for the mini_pipline graph.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
55 52 :title='stage.title' 56 53 data-placement="top" 57 54 data-toggle="dropdown" 58 type="button"> 55 type="button" 56 > 59 57 <span v-html="svg"></span> 60 58 <i class="fa fa-caret-down "></i> 61 59 </button> 62 60 <ul class="dropdown-menu mini-pipeline-graph-dropdown-menu js-builds-dropdown-container"> 63 61 <div class="arrow-up"></div> 64 <div :class="dropdownClass" class="js-builds-dropdown-list scrollable-menu" v-html="buildsOrSpinner"></div> 62 <div 63 @click='' @grzesiek Here is a new fix. Try it out! I will work on it on the airplane. If we merge this tomorrow will this be released?
mentioned in merge request !8542 (merged)
added 35 commits
-
4fb4f615...e2f0b830 - 34 commits from branch
master
- 28e77da9 - Merge branch 'master' into ui_pipelines_mini_graph
-
4fb4f615...e2f0b830 - 34 commits from branch
Ok this works in FF, Chrome, SF. Behaviour is as follows:
- If never clicked: API call is made
- If dropdown is present a new API call is not made
- If dropdown is present and a build is clicked, client gets redirected to build
- If dropdown is present and the url bar is clicked, dropdown is still present
This seems to work 100%
Edited by Regis Boudinot- Resolved by Fatih Acet
@grzesiek Now they can see new information even if the page they are on has not changed
It almost looks like a realtime dropdown
Edited by Regis Boudinotassigned to @fatihacet
@fatihacet Ok I retried the latest pipeline since it timed out in the first stage. If it fails, I will push up merged master to make it fire a new pipeline.
changed milestone to %8.16
added 27 commits
-
97610fda...f208897c - 24 commits from branch
master
- d143cae9 - Merge branch 'master' into ui_pipelines_mini_graph
- 6a57e93f - Merge branch 'master' into ui_pipelines_mini_graph
- e6753362 - use destructuring syntax instead
Toggle commit list-
97610fda...f208897c - 24 commits from branch
@fatihacet retrying latest pipeline since there were multiple timeouts
mentioned in commit 61b6643e
mentioned in commit 78418c89