Skip to content
Snippets Groups Projects

better UI fix - simple solution - pipelines#index mini_graph in Vue

Merged Regis Boudinot requested to merge ui_pipelines_mini_graph into master
1 unresolved thread

What does this MR do?

Enables a user to make multiple calls for the mini_pipline graph.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

2017-01-17_11.49.03

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports

Pipeline #5890188 passed

Pipeline passed for e6753362 on ui_pipelines_mini_graph

Test coverage 92.61% from 1 job

Merged by avatar (Mar 10, 2025 4:22am UTC)

Loading

Pipeline #5894959 failed

Pipeline failed for 61b6643e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
55 52 :title='stage.title'
56 53 data-placement="top"
57 54 data-toggle="dropdown"
58 type="button">
55 type="button"
56 >
59 57 <span v-html="svg"></span>
60 58 <i class="fa fa-caret-down "></i>
61 59 </button>
62 60 <ul class="dropdown-menu mini-pipeline-graph-dropdown-menu js-builds-dropdown-container">
63 61 <div class="arrow-up"></div>
64 <div :class="dropdownClass" class="js-builds-dropdown-list scrollable-menu" v-html="buildsOrSpinner"></div>
62 <div
63 @click=''
  • Author Contributor

    @grzesiek Here is a new fix. Try it out! I will work on it on the airplane. If we merge this tomorrow will this be released?

  • Regis Boudinot added ~19173 ~127616 ~12980 labels

    added ~19173 ~127616 ~12980 labels

  • Regis Boudinot marked as a Work In Progress

    marked as a Work In Progress

  • Regis Boudinot mentioned in merge request !8542 (merged)

    mentioned in merge request !8542 (merged)

  • Regis Boudinot added 35 commits

    added 35 commits

    Compare with previous version

  • Regis Boudinot added 2 commits

    added 2 commits

    • 96b7865b - fix UI behaviour - only make new calls when button is clicked and dropdown is not displayed
    • 97610fda - get rid of log

    Compare with previous version

  • Author Contributor

    Ok this works in FF, Chrome, SF. Behaviour is as follows:

    1. If never clicked: API call is made
    2. If dropdown is present a new API call is not made
    3. If dropdown is present and a build is clicked, client gets redirected to build
    4. If dropdown is present and the url bar is clicked, dropdown is still present

    This seems to work 100% :tada:

    @grzesiek @fatihacet ^^

    Edited by Regis Boudinot
  • Fatih Acet
  • Author Contributor

    2017-01-17_17.35.25

  • Author Contributor

    @grzesiek Now they can see new information even if the page they are on has not changed :rocket:

    It almost looks like a realtime dropdown :joy:

    Edited by Regis Boudinot
  • Regis Boudinot added ~149423 label

    added ~149423 label

  • Author Contributor

    @fatihacet Ok I retried the latest pipeline since it timed out in the first stage. If it fails, I will push up merged master to make it fire a new pipeline.

  • Regis Boudinot unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Regis Boudinot changed title from WIP: better UI fix - simple solution to better UI fix - simple solution - pipelines#index mini_graph in Vue

    changed title from WIP: better UI fix - simple solution to better UI fix - simple solution - pipelines#index mini_graph in Vue

  • Regis Boudinot changed milestone to %8.16

    changed milestone to %8.16

  • Regis Boudinot added 27 commits

    added 27 commits

    • 97610fda...f208897c - 24 commits from branch master
    • d143cae9 - Merge branch 'master' into ui_pipelines_mini_graph
    • 6a57e93f - Merge branch 'master' into ui_pipelines_mini_graph
    • e6753362 - use destructuring syntax instead

    Compare with previous version

  • Author Contributor

    @fatihacet retrying latest pipeline since there were multiple timeouts

  • Author Contributor

    Yay it passed! :tada:

  • Fatih Acet mentioned in commit 61b6643e

    mentioned in commit 61b6643e

  • merged

  • Picked into 8-16-stable, will go into 8.16.0-rc4

  • James Lopez removed ~149423 label

    removed ~149423 label

  • Fatih Acet mentioned in commit 78418c89

    mentioned in commit 78418c89

  • Please register or sign in to reply
    Loading