Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !8507

Use #parts instead of #part to read all the parts of the Message.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rubén Dávila requested to merge fix-plain-text-emails into master Jan 09, 2017
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

What does this MR do?

Fix an incorrect usage of a method to read the parts of an email message.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

It was adding an extra empty Mime section which was giving issues in some mail clients. You can see more information related to this here: https://productforums.google.com/forum/#!topic/gmail/aVoLmVuhV_c

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #26463 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-plain-text-emails