Skip to content
Snippets Groups Projects

Gitlab::LDAP::Person uses LDAP attributes configuration

Merged Drew Blessing requested to merge dblessing/gitlab-ce:ldap_person_attributes into master
All threads resolved!

What does this MR do?

We allow users to configure LDAP attribute preferences. For example, email can be configured to use mail, email and userPrincipalName, falling through to the next until a value is found. Prior to this change, Gitlab::LDAP::Person did not honor this configuration. Now, the class will honor name and mail configuration. It does not handle username, or fallback to first_name + last_name in the absence of name.

Closes #26290 (closed)

cc/ @MrChrisW

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Drew Blessing resolved all discussions

    resolved all discussions

  • Drew Blessing added 1 commit

    added 1 commit

    • f6de53e0 - Gitlab::LDAP::Person uses LDAP attributes configuration

    Compare with previous version

  • Drew Blessing resolved all discussions

    resolved all discussions

  • Drew Blessing added 1 commit

    added 1 commit

    • 5dd29984 - Gitlab::LDAP::Person uses LDAP attributes configuration

    Compare with previous version

  • Drew Blessing added 1 commit

    added 1 commit

    • babb7d52 - Gitlab::LDAP::Person uses LDAP attributes configuration

    Compare with previous version

  • Drew Blessing resolved all discussions

    resolved all discussions

  • @dblessing LGTM. Feel free to change milestone and add ~"Pick into Stable" if you think this needs to be in an 8.15 patch.

  • Robert Speicher changed milestone to %8.16

    changed milestone to %8.16

  • Robert Speicher enabled an automatic merge when the pipeline for babb7d52 succeeds

    enabled an automatic merge when the pipeline for babb7d52 succeeds

  • Author Maintainer

    Thanks @rspeicher

  • Drew Blessing added ~149423 label

    added ~149423 label

  • Drew Blessing changed milestone to %8.15

    changed milestone to %8.15

  • Robert Speicher mentioned in commit 115aac77

    mentioned in commit 115aac77

  • Picked into 8-15-stable. Will go into 8.15.3.

  • Douglas Barbosa Alexandre removed ~149423 label

    removed ~149423 label

  • Robert Speicher mentioned in commit dbbac3e9

    mentioned in commit dbbac3e9

  • Drew Blessing mentioned in merge request !8465 (merged)

    mentioned in merge request !8465 (merged)

  • Please register or sign in to reply
    Loading