Remove bottom border from Issuable titles

➜  gitlab master ✓ bundle exec rspec ./spec/features/milestones/milestones_spec.rb

  1) Milestone draggable issues allows admin to drag issue
     Failure/Error: super

     ActionController::RoutingError:
       No route matches [PUT] "/namespace3/project3/milestones/1/sort_issues"
     # ./lib/gitlab/middleware/static.rb:9:in `call'


  2) Milestone draggable merge requests allows admin to drag merge request
     Failure/Error: super

     ActionController::RoutingError:
       No route matches [PUT] "/namespace6/project6/merge_requests/1"
     # ./lib/gitlab/middleware/static.rb:9:in `call'

 8/8 |============== 100 =================>| Time: 00:00:24

Finished in 24.97 seconds (files took 14.83 seconds to load)
8 examples, 2 failures

Failed examples:

rspec ./spec/features/milestones/milestones_spec.rb:32 # Milestone draggable issues allows admin to drag issue
rspec ./spec/features/milestones/milestones_spec.rb:64 # Milestone draggable merge requests allows admin to drag merge request

It fails for me locally on this branch and even on master and it also fails on CI but I'm not sure why since I don't see other MRs failing because of this.

Some things I did

If I relocate the failing test at the top of the context it passes but another test fails. I suspect it has to do with some caching on the app or something is not reset after each test.
A request to /namespace6/project6/merge_requests/1 is triggered twice when dragging a MR to another column. Even fixing this on the JS it fails for the same reason, so the app triggering simultaneous requests is not the cause of the error.
I've tried refactoring the spec putting each test in separate contexts and it fails for the same reason.

This MR is just CSS, so I'm not introducing anything new, weird this has not been caught already on master.

/cc @smcgivern, @dzaporozhets (I think you were working on routes lately), and @blackst0ne (since it seems you originally wrote this file)

@alfredo1 looks like common "not finished ajax request" problem. I will make MR with fix. Strange it did not catch by CI

UPDATE: mr with fix at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8361

mentioned in merge request !8361 (merged)

mentioned in issue #26183 (closed)

@dzaporozhets thank you so much!!

added 18 commits

174065f4...b0765d24 - 17 commits from branch master
0ca1f733 - Remove bottom border from issuable title

Compare with previous version

added 1 commit

eeca61ef - Remove bottom border from issuable title

Compare with previous version

mentioned in merge request !8372 (closed)

added 1 commit

8a3cf4a9 - Remove bottom border from issuable titles

Compare with previous version

@annabeldunstone I've updated the MR, I think issuable.scss is a better place for this since the previous one was affecting the milestones pages too.

assigned to @annabeldunstone

added ~149423 and removed ~978334 labels

Great! Thanks @alfredo1

merged

mentioned in commit b561b167

Picked into 8-15-stable. Will go into 8.15.3.

removed ~149423 label

mentioned in issue #26163 (closed)

mentioned in commit 5836888e

Remove bottom border from Issuable titles

Merge request reports

Activity