An error occurred while fetching the assigned milestone of the selected merge_request.
Allow projects with dashboard as path
What does this MR do?
Allow projects with dashboard as path
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
There are a lot of projects with name dashboard
. Now it gives people 404 because its reserved. I believe we can whitelist this name because we use dashboard only for top level routing and won't conflict with it.
Screenshots (if relevant)
no
Does this MR meet the acceptance criteria?
-
Changelog entry added - Tests
-
Added for this feature/bug2fa I don't think we need tests for constant -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
marked the task Squashed related commits together as completed
marked the task Conform by the style guides as completed
marked the task Conform by the merge request performance guides as completed
marked the task Changelog entry added as completed
assigned to @DouweM
enabled an automatic merge when the pipeline for 8b92e9c0 succeeds
mentioned in commit f603e423
mentioned in issue #25893 (closed)
mentioned in commit efc97cbc
mentioned in merge request !8227 (merged)
mentioned in issue #25917 (closed)
Please register or sign in to reply