Skip to content
Snippets Groups Projects

Fix Import/Export labels error

Merged James Lopez requested to merge fix/import-labels-error into master
All threads resolved!

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24257

For existing labels that have already been created for merge requests or issues, we should avoid keeping the priorities in the hash as they have also been created already and it will throw an error trying to update the label that already has

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Douwe Maan resolved all discussions

    resolved all discussions

  • Author Maintainer

    @DouweM I think updating the JSON is enough, it's basically replicating the exact problem and project_restorer_spec.rb will fail with exact the same error as the original issue.

  • James Lopez marked the task Added for this feature/bug as completed

    marked the task Added for this feature/bug as completed

  • James Lopez marked the task Conform by the merge request performance guides as completed

    marked the task Conform by the merge request performance guides as completed

  • James Lopez marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • James Lopez marked the task Conform by the style guides as completed

    marked the task Conform by the style guides as completed

  • assigned to @DouweM

  • merged

  • Douwe Maan mentioned in commit 87b01636

    mentioned in commit 87b01636

  • Douwe Maan mentioned in commit 33227197

    mentioned in commit 33227197

  • Author Maintainer

    Picked into 8-15-stable, will go into 8.15.0-rc4

  • James Lopez removed ~149423 label

    removed ~149423 label

  • James Lopez mentioned in merge request !19961 (merged)

    mentioned in merge request !19961 (merged)

  • Please register or sign in to reply
    Loading