Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !8146

Memoize Milestoneish#issues_visible_to_user to reduce lookups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged James Edwards-Jones requested to merge jej-memoize-milestoneish-visible-to-user into master Dec 16, 2016
  • Overview 21
  • Commits 1
  • Pipelines 13
  • Changes 4

What does this MR do?

https://gitlab.com/gitlab-org/gitlab-ce/issues/25748

Milestones page are erroring out with 502 due to Milestoneish#issues_visible_to_user taking too long.This patch attempts to provide a temporary improvement by reducing the number of times it is called, and speeding up the SQL query when it is on an individual milestone.

GlobalMilestones used on the Dashboard and in Groups still have a very slow SQL query so the issue is being left open.

Versions affected

8.13, 8.14. 8.15

Severity

Important, partially fixes broken milestones index.

Does this MR meet the acceptance criteria?

  • Changelog entry added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/25748

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: jej-memoize-milestoneish-visible-to-user