Extend code review docs with chapter about the right balance
What does this MR do?
This MR extends the code review docs with chapter about the right balance.
Merge request reports
Activity
@DouweM @rspeicher @rymai Can you take a look? Thanks!
Added 1 commit:
- 62418031 - Extend code review docs with chapter about the right balance
@grzesiek General idea seems fine.
Needs some grammar fixes but I wasn't sure if we're at that point here so I haven't left notes yet.Added 1 commit:
- 5b052605 - Extend code review docs with chapter about the right balance
@rspeicher I pushed some grammar-related changes, is it better now ?
Doesn't it feel a little too moralistic?@grzesiek Thanks! I think that's really good, I'll let @rspeicher do the typo/English nitpicks! :)
Doesn't it feel a little too moralistic?
I think that's ok.
Reassigned to @rspeicher
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
@grzesiek Looks good, just some minor fixes!
Reassigned to @grzesiek
Added 1 commit:
- 7a25f478 - Copy-edit text about right balance in code reviews
Reassigned to @rspeicher
Added 1 commit:
- 85c4aa4a - Copy-edit text about right balance in code reviews
- Resolved by Grzegorz Bizon
@grzesiek Sorry, one last question that I thought I had already asked.
Reassigned to @grzesiek
added 1 commit
- ebef1a84 - Remove change to MWBS in code review guideline
assigned to @rspeicher
mentioned in commit 63b57e5e